From 7d9dc66236d53cd40cb28d6c73dcefe9b1bf8310 Mon Sep 17 00:00:00 2001 From: wj-chen Date: Fri, 15 Sep 2023 14:50:58 -0700 Subject: [PATCH] Update documentation for google_bigquery_table.time_partitioning.expiration_ms (#8827) --- mmv1/products/bigquery/Table.yaml | 5 ++++- .../terraform/services/bigquery/resource_bigquery_table.go | 7 +++++-- .../services/bigquery/resource_bigquery_table_test.go | 1 + 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/mmv1/products/bigquery/Table.yaml b/mmv1/products/bigquery/Table.yaml index ae9c5bb81666..5b0d92ec3f9b 100644 --- a/mmv1/products/bigquery/Table.yaml +++ b/mmv1/products/bigquery/Table.yaml @@ -175,7 +175,10 @@ properties: name: 'expirationMs' description: | Number of milliseconds for which to keep the storage for a - partition. + partition. If unspecified when the table is created in a dataset + that has `defaultPartitionExpirationMs`, it will inherit + the value of `defaultPartitionExpirationMs` from the dataset. + To specify a unlimited expiration, set the value to 0. - !ruby/object:Api::Type::String name: 'field' description: | diff --git a/mmv1/third_party/terraform/services/bigquery/resource_bigquery_table.go b/mmv1/third_party/terraform/services/bigquery/resource_bigquery_table.go index f32333ec90b4..e8568fea396d 100644 --- a/mmv1/third_party/terraform/services/bigquery/resource_bigquery_table.go +++ b/mmv1/third_party/terraform/services/bigquery/resource_bigquery_table.go @@ -865,8 +865,11 @@ func ResourceBigQueryTable() *schema.Resource { Description: `If specified, configures time-based partitioning for this table.`, Elem: &schema.Resource{ Schema: map[string]*schema.Schema{ - // ExpirationMs: [Optional] Number of milliseconds for which to keep the - // storage for a partition. + // ExpirationMs: [Optional] Number of milliseconds for which to keep the storage for a + // partition. If unspecified when the table is created in a dataset that has + // `defaultPartitionExpirationMs`, it will inherit the value of + // `defaultPartitionExpirationMs` from the dataset. + // To specify a unlimited expiration, set the value to 0. "expiration_ms": { Type: schema.TypeInt, Optional: true, diff --git a/mmv1/third_party/terraform/services/bigquery/resource_bigquery_table_test.go b/mmv1/third_party/terraform/services/bigquery/resource_bigquery_table_test.go index 8c6e63d11931..46a7224eb043 100644 --- a/mmv1/third_party/terraform/services/bigquery/resource_bigquery_table_test.go +++ b/mmv1/third_party/terraform/services/bigquery/resource_bigquery_table_test.go @@ -1441,6 +1441,7 @@ resource "google_bigquery_table" "test" { type = "%s" field = "ts" require_partition_filter = true + expiration_ms = 1000 } clustering = ["some_int", "some_string"] schema = <