From 33e2ef5365d58eafeb417a1c726cdd167e338371 Mon Sep 17 00:00:00 2001 From: pengq-google Date: Mon, 11 Sep 2023 11:50:47 -0400 Subject: [PATCH] Add google_logging_metric to version 5 upgrade doc for #8780 (#8887) Co-authored-by: Cameron Thornton --- .../docs/guides/version_5_upgrade.html.markdown | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown b/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown index f1aed2ca0784..0e5eaa65dde4 100644 --- a/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown +++ b/mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown @@ -385,6 +385,18 @@ If you were relying on accessing an individual flag by index (for example, `goog Previously, the default value for `rule.rate_limit_options.encorce_on_key` is "ALL", now this field no longer has a default value. +## Resource: `google_logging_metric` + +### Additional `bucket_options` subfields are now properly required + +When setting the `bucket_options` block, the following fields may be required: + +* `num_finite_buckets`, `width`, and `offset` are now required when `bucket_options.linear_buckets` is set. + +* `num_finite_buckets`, `growth_factor`, and `scale` are now required when `bucket_options.exponential_buckets` is set. + +Previously these fields should have been required but were not, which allowed for invalid `google_logging_metric` configurations. + ## Resource: `google_logging_project_sink` ### `unique_writer_identity` now defaults to `TRUE` @@ -437,4 +449,4 @@ resource "google_project_iam_binding" "gcs-bucket-writer" { ### `Create` endpoint is used to create the resource -`google_service_networking_connection` now uses the Create endpoint instead of the Patch endpoint during the creation step. Previously, Patch was used as a workaround for an issue that has since been resolved. \ No newline at end of file +`google_service_networking_connection` now uses the Create endpoint instead of the Patch endpoint during the creation step. Previously, Patch was used as a workaround for an issue that has since been resolved.