From 72bc251cf4dc1b7158fef531bf87d178c98d5bf1 Mon Sep 17 00:00:00 2001 From: justinsb Date: Sat, 16 Mar 2024 07:18:53 -0400 Subject: [PATCH] chore: avoid changing name of tests I think the test method name (the first component) is sufficient here, and then we don't need to change the test paths for "normal" TestAllInSeries. --- tests/e2e/unified_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/e2e/unified_test.go b/tests/e2e/unified_test.go index aa33dfbeae..386c8fdb74 100644 --- a/tests/e2e/unified_test.go +++ b/tests/e2e/unified_test.go @@ -83,7 +83,7 @@ func TestAllInSeries(t *testing.T) { } }) - testFixturesInSeries(ctx, t, "AllInSeries", false, cancel) + testFixturesInSeries(ctx, t, false, cancel) } // TestPauseInSeries is a basic smoke test to prove that if CC pauses actuation of resources @@ -96,10 +96,10 @@ func TestPauseInSeries(t *testing.T) { cancel() }) - testFixturesInSeries(ctx, t, "PauseInSeries", true, cancel) + testFixturesInSeries(ctx, t, true, cancel) } -func testFixturesInSeries(ctx context.Context, t *testing.T, testName string, testPause bool, cancel context.CancelFunc) { +func testFixturesInSeries(ctx context.Context, t *testing.T, testPause bool, cancel context.CancelFunc) { t.Helper() if os.Getenv("RUN_E2E") == "" { @@ -109,7 +109,7 @@ func testFixturesInSeries(ctx context.Context, t *testing.T, testName string, te t.Skip("GOLDEN_REQUEST_CHECKS not set; skipping as this test relies on the golden files.") } - t.Run(fmt.Sprintf("%s/fixtures", testName), func(t *testing.T) { + t.Run("fixtures", func(t *testing.T) { fixtures := resourcefixture.Load(t) for _, fixture := range fixtures { fixture := fixture