Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to generated AlloyDBAdminAsyncClient over aiohttp.ClientSession #221

Open
jackwotherspoon opened this issue Jan 18, 2024 · 0 comments
Open

Switch to generated AlloyDBAdminAsyncClient over aiohttp.ClientSession #221

jackwotherspoon opened this issue Jan 18, 2024 · 0 comments
Assignees
@enocom
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@jackwotherspoon
Copy link
Collaborator

AlloyDB has a generated package with support for an async client. Should look at switching to use it over the aiohttp.ClientSession that is currently being used to hit the admin API endpoints. Will want to investigate performance a bit before committing to this switch in case it degrades the performance.

AlloyDB Client package: https://pypi.org/project/google-cloud-alloydb/

Generated client: https://github.com/googleapis/google-cloud-python/blob/main/packages/google-cloud-alloydb/google/cloud/
@jackwotherspoon jackwotherspoon added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jan 18, 2024
@jackwotherspoon jackwotherspoon self-assigned this Jan 18, 2024
@enocom enocom assigned enocom and unassigned jackwotherspoon Sep 6, 2024
@enocom enocom added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enocom enocom

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@enocom @jackwotherspoon