From 8d4e4fbd002222d0817a0633ef4900d28593fbec Mon Sep 17 00:00:00 2001 From: Dev Aggarwal Date: Wed, 26 Jun 2024 22:36:28 +0530 Subject: [PATCH] add gcp_project gcp_region env vars --- .env.example | 2 ++ .github/workflows/python-tests.yml | 4 +++- README.md | 1 + daras_ai_v2/settings.py | 3 +-- 4 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.env.example b/.env.example index 91b9fb9ab..af660dc62 100644 --- a/.env.example +++ b/.env.example @@ -2,6 +2,8 @@ APP_BASE_URL=http://localhost:3000 API_BASE_URL=http://localhost:8080 ADMIN_BASE_URL=http://localhost:8000 +GCP_PROJECT=dara-c1b52 +GCP_REGION=us-central1 GS_BUCKET_NAME=dara-c1b52.appspot.com PGHOST=127.0.0.1 diff --git a/.github/workflows/python-tests.yml b/.github/workflows/python-tests.yml index d88f68262..979f1c726 100644 --- a/.github/workflows/python-tests.yml +++ b/.github/workflows/python-tests.yml @@ -81,8 +81,10 @@ jobs: APP_BASE_URL: http://localhost:3000 API_BASE_URL: http://localhost:8080 ADMIN_BASE_URL: http://localhost:8000 + GCP_PROJECT: ${{ env.GCP_PROJECT }} + GCP_REGION: $${{ env.GCP_REGION }} + GS_BUCKET_NAME: $${{ env.GS_BUCKET_NAME }} GOOGLE_APPLICATION_CREDENTIALS_JSON: ${{ secrets.GOOGLE_APPLICATION_CREDENTIALS_JSON }} - GS_BUCKET_NAME: ${{ secrets.GS_BUCKET_NAME }} STRIPE_SECRET_KEY: ${{ secrets.STRIPE_SECRET_KEY }} ELEVEN_LABS_API_KEY: ${{ secrets.ELEVEN_LABS_API_KEY }} AZURE_SPEECH_REGION: ${{ secrets.AZURE_SPEECH_REGION }} diff --git a/README.md b/README.md index ca0f30cb8..ad70f1dd7 100644 --- a/README.md +++ b/README.md @@ -33,6 +33,7 @@ - Firebase Authentication Admin - Storage Admin 5. Create and Download a JSON Key for this service account and save it to the project root as `serviceAccountKey.json`. +6. Add your project & bucket name to `.env` * Run tests to see if everything is working fine: ``` diff --git a/daras_ai_v2/settings.py b/daras_ai_v2/settings.py index f734766a2..14e0c24b8 100644 --- a/daras_ai_v2/settings.py +++ b/daras_ai_v2/settings.py @@ -226,8 +226,7 @@ GCP_PROJECT = config("GCP_PROJECT", default="dara-c1b52") GCP_REGION = config("GCP_REGION", default="us-central1") - -GS_BUCKET_NAME = config("GS_BUCKET_NAME", default="") +GS_BUCKET_NAME = config("GS_BUCKET_NAME", default="dara-c1b52.appspot.com") GS_MEDIA_PATH = config("GS_MEDIA_PATH", default="daras_ai/media") GOOGLE_CLIENT_ID = config("GOOGLE_CLIENT_ID", default="")