Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: in 4.5 and in 4.3.1.sp1, server responding with 200 even when request is not correct #1843

Closed
yurem opened this issue Jun 2, 2023 · 2 comments
Closed

fix: in 4.5 and in 4.3.1.sp1, server responding with 200 even when request is not correct #1843

yurem opened this issue Jun 2, 2023 · 2 comments

Comments

@yurem
Copy link
Contributor

yurem commented Jun 2, 2023 •
edited
Loading

In 4.5 and in 4.3.1.sp1, server responding with 200 even when request is not correct ( oxAuth.log showing error ).

I think we shouldn't allow server to respond with 200 and empty body. Better to make server response with 401 ( which is working in 4.4.2.sp1.

Can we make 4.5 and 4.3.1 same as 4.4.2.sp1?

Here is a GIF attached below to describe the situation:

200_empty_body

Originally posted by @mzico in #1773 (comment)
@yurem
Copy link
Contributor Author

yurem commented Jun 2, 2023

The issue is in MTLS part of Authentication Filter

@yurem yurem changed the title fix: In 4.5 and in 4.3.1.sp1, server responding with 200 even when request is not correct ( oxAuth.log showing error ). fix: in 4.5 and in 4.3.1.sp1, server responding with 200 even when request is not correct ( oxAuth.log showing error ). Jun 2, 2023
@yurem yurem changed the title fix: in 4.5 and in 4.3.1.sp1, server responding with 200 even when request is not correct ( oxAuth.log showing error ). fix: in 4.5 and in 4.3.1.sp1, server responding with 200 even when request is not correct Jun 2, 2023
yurem added a commit that referenced this issue Jun 2, 2023
@yurem
fix: in 4.5 and in 4.3.1.sp1, server responding with 200 even when
43b1764 
request is not correct #1843
@yurem yurem mentioned this issue Jun 2, 2023
Merged
yurem added a commit that referenced this issue Jun 2, 2023
@yurem
fix: in 4.5 and in 4.3.1.sp1, server responding with 200 even when (#…
ddde674 
…1844)

request is not correct #1843
yurem added a commit that referenced this issue Jun 2, 2023
@yurem
fix: in 4.5 and in 4.3.1.sp1, server responding with 200 even when (#…
2bd631a 
…1844)

request is not correct #1843
yurem added a commit that referenced this issue Jun 2, 2023
@yurem
fix: in 4.5 and in 4.3.1.sp1, server responding with 200 even when (#…
11b0008 
…1844)

request is not correct #1843
@yurem
Copy link
Contributor Author

yurem commented Jun 2, 2023

fixed

@yurem yurem closed this as completed Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yurem