Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use data packs for recipes [$30] #6

Closed
mastercoms opened this issue Sep 15, 2019 · 1 comment
Closed

Use data packs for recipes [$30] #6

mastercoms opened this issue Sep 15, 2019 · 1 comment
Labels
bounty data A feature involving internal representations of blocks, items, properties, and more. non-essential A feature that is part of the 1.13 update, but not required for the 1.13 platform update. serialization A feature involving data serialization/deserialization. server An internal technical feature.

Comments

@mastercoms
Copy link
Member

mastercoms commented Sep 15, 2019 •
edited
Loading

This issue is part of the 1.13.x compatibility Epic.

All contributions are subject to the Glowstone CLA. In short, contributions must not contain any content (code or otherwise) copied from,
inspired by or based upon content from Mojang or third-party projects that are based on such content (CraftBukkit, Spigot, Forge, ...).

Description:

We currently use a custom system for representing crafting data, but this should be replaced with a data pack based system.

Reference Documentation:

https://minecraft.gamepedia.com/Recipe

Relevant Code:

https://github.com/GlowstoneMC/Glowstone/blob/1.13/src/main/java/net/glowstone/inventory/crafting/CraftingManager.java
https://github.com/GlowstoneMC/Glowstone/blob/1.13/src/main/resources/builtin/recipes.yml

Related to:

#4

There is a $30 open bounty on this issue. Add to the bounty at Bountysource.
@mastercoms mastercoms mentioned this issue Sep 15, 2019
Open
8 tasks
@mastercoms mastercoms added data A feature involving internal representations of blocks, items, properties, and more. serialization A feature involving data serialization/deserialization. server An internal technical feature. essential A feature that must be implemented for 1.13 base support. non-essential A feature that is part of the 1.13 update, but not required for the 1.13 platform update. and removed essential A feature that must be implemented for 1.13 base support. labels Sep 15, 2019
@mastercoms mastercoms changed the title Use data packs for recipes Use data packs for recipes [$30] Sep 23, 2019
@KisaragiEffective KisaragiEffective mentioned this issue Oct 15, 2019
Closed
2 tasks
@KisaragiEffective KisaragiEffective mentioned this issue Nov 29, 2019
Closed
3 tasks
@smartboyathome
Copy link

This has been implemented by the redstone-transformer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bounty data A feature involving internal representations of blocks, items, properties, and more. non-essential A feature that is part of the 1.13 update, but not required for the 1.13 platform update. serialization A feature involving data serialization/deserialization. server An internal technical feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] RE:replace static recipe with datapack KisaragiEffective/Glowstone
2 participants
@smartboyathome @mastercoms