Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests [$100] #29

Open
mastercoms opened this issue Sep 22, 2019 · 3 comments
Open

Fix tests [$100] #29

mastercoms opened this issue Sep 22, 2019 · 3 comments
Labels
bounty essential A feature that must be implemented for 1.13 base support. good first issue Good for newcomers server An internal technical feature.

Comments

@mastercoms
Copy link
Member

mastercoms commented Sep 22, 2019

This issue is part of the 1.13.x compatibility Epic.

All contributions are subject to the Glowstone CLA. In short, contributions must not contain any content (code or otherwise) copied from,
inspired by or based upon content from Mojang or third-party projects that are based on such content (CraftBukkit, Spigot, Forge, ...).


Description:

Most of our tests were made with pre-1.13 IDs and structures in mind. We need to update tests after implementing all other features, to make them use 1.13 features and interfaces that we create when adding 1.13 support.

Relevant Code:

https://github.com/GlowstoneMC/Glowstone/tree/1.13/src/test


There is a $100 open bounty on this issue. Add to the bounty at Bountysource.

@mastercoms mastercoms added essential A feature that must be implemented for 1.13 base support. server An internal technical feature. good first issue Good for newcomers labels Sep 22, 2019
@mastercoms mastercoms changed the title Fix tests Fix tests [$100] Sep 23, 2019
@mastercoms mastercoms changed the title Fix tests [$100] Fix tests [$200] Sep 23, 2019
@mastercoms mastercoms changed the title Fix tests [$200] Fix tests [$100] Sep 23, 2019
@SsorWayfinder
Copy link

I can take this on if no one else has shown interest.

@mastercoms
Copy link
Member Author

Sure! But please talk with us on Discord to make sure we have good tests that don't conflict with what we have in mind for the implementation.

@SsorWayfinder
Copy link

Based on our conversations on the discord, the desired end result is to make the set up and action tested to be done in the 1.13 way.

The results of interacting with the source in a 1.13 way should pass, even if it's not the behavior we'll eventually want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty essential A feature that must be implemented for 1.13 base support. good first issue Good for newcomers server An internal technical feature.
Projects
None yet
Development

No branches or pull requests

2 participants