PIPELINE-1860 Added Papua New Guinea normalization pipeline #22
Conversation
…d speed and course
…lculate implied speed and course
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2d2db44. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
packages/pipe-vms-ingestion/tests/vms_ingestion/normalization/feeds/test_png_normalize.py
Show resolved
Hide resolved
| self.start_date = parse_yyyy_mm_dd_param(params.start_date).replace( | ||
| tzinfo=dt.timezone.utc | ||
| ) | ||
| self.end_date = parse_yyyy_mm_dd_param(params.end_date).replace( | ||
| tzinfo=dt.timezone.utc | ||
| ) |
There was a problem hiding this comment.
Isn't this something we might want to have embedded in the parse_yyyy_mm_dd_param function instead of here? I can't find a reason why we might want to include local tz logic anywhere.
There was a problem hiding this comment.
Makes sense, I'll move it. Thanks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #22 +/- ##
============================================
+ Coverage 0 76.58% +76.58%
============================================
Files 0 46 +46
Lines 0 756 +756
Branches 0 69 +69
============================================
+ Hits 0 579 +579
- Misses 0 159 +159
- Partials 0 18 +18 ☔ View full report in Codecov by Sentry. |
https://globalfishingwatch.atlassian.net/browse/PIPELINE-1860
start_dateso that implied speed and course can be calculated for the first position of every vessel instart_date, otherwise it wasnullFilterDateRangetransformation to exclude those additional positions beforestart_datefrom the output so that they are not stored in BQ.