-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve nomenclature consistency #146
Comments
The tinyest change to avoid a long explanation is renaming |
…`) and adding error messages for vesselId search. renaming `id` to `vesselId` in `selfReportedInfo` (#146). details: add key to last report for consistency.
|
Hi. Hope you don't mind me jumping in, but I had a thought about argument naming! I notice in the latest version of |
Thanks for flagging this, @jflowernet ! I made a correction to |
|
Vessel ID
Vessel IDs, vessel IDs, vesselID (in the table), and VesselID (in the documentation) are spelled in many ways in different places.
id
inget_vessel_info()
andvessels
in other functionsid
orvesselId
in the API results (selReportedInfo$id
,combinedSourcesInfo$VesselID
but there are other fields namedid
in the returning datasets that are not vessel IDs likeregistryInfo$id
Possible discussion with the API team as well to avoid solving downstream.
The text was updated successfully, but these errors were encountered: