Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thirst restoration not working with automated food consumption from Sophisticated Backpacks #890

Open
DuraBrite opened this issue Nov 15, 2024 · 0 comments

Comments

@DuraBrite
Copy link

What's the issue you encountered?

The "Feeding Upgrade" in the Sophisticated Backpacks mod no longer increases the player's thirst level when consuming food with a designated thirst value.
This issue was first noticed after updating Tough As Nails from version 9.0.0.96 to 9.2.0.171 on Minecraft 1.20.1 (Forge 47.3.11).
Additional testing revealed that the issue persists in the latest version of Tough As Nails NeoForge 1.21.1-10.1.0.13.

Before the update, food items with assigned thirst values (e.g., melon slices with a 1 thirst value) restored both hunger and thirst when consumed automatically by the Feeding Upgrade. Currently, only hunger is restored.

How can the issue be reproduced?

  1. Install Tough As Nails 1.20.1 9.2.0.171 (or 1.21.1-10.1.0.13), Sophisticated Backpacks, and Sophisticated Core.
  2. Create a data pack to assign a thirst value to a food item, such as melon slices. Example JSON for the file located at _toughasnails/tags/items/thirst/2_thirst_drinks.json_:
    {
      "replace": true,
      "values": [
        "minecraft:melon_slice"
      ]
    }
  3. Add the Feeding Upgrade to a Sophisticated Backpack and insert melon slices.
  4. Allow the Feeding Upgrade to automatically consume melon slices when the player's hunger and thirst decreased.
  5. Observe that the player's thirst level is not affected, even though the melon slice has a designated thirst value.

Logs

the issue does not cause crashes or specific log outputs

Mod Version

9.2.0.171

Additional information

This issue appears to involve an incompatibility between Tough As Nails' thirst system and the Feeding Upgrade logic in Sophisticated Backpacks. The issue did not exist in Tough As Nails version 9.0.0.96.

This issue was also reported under Sophisticated Backpacks. However, the mod author indicated that they are firing the correct methods/events for player eating behavior and suggested reporting the issue here. They mentioned that Tough As Nails should investigate, as no special compatibility changes were made on their end and similar features work with other mods (e.g., Spice of Life).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant