You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This message regularly shows up on my service worker's console. It's not a big deal, but it gets a bit annoying, especially when I'm spending a long time debugging something with my own console logs. As a library, ExtPay should not log anything.
To Reproduce
Steps to reproduce the behavior:
Include ExtPay in any project
Start the background page
Send a runtime message
Observe the message on the service worker's console
Since these event names are pretty generic, someone can easily pick the same ones for their own events, making it possible that ExtPay picks up unintended events.
The text was updated successfully, but these errors were encountered:
Describe the bug
This is a minor issue. The message listener in ExtPay prints a log message:
https://github.com/Glench/ExtPay/blob/main/ExtPay.dev.js#L310
This message regularly shows up on my service worker's console. It's not a big deal, but it gets a bit annoying, especially when I'm spending a long time debugging something with my own console logs. As a library, ExtPay should not log anything.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
ExtPay prints no logs.
Additional context
In addition, because ExtPay's own events are not prefixed, there is a possibility of event clashes. Example:
https://github.com/Glench/ExtPay/blob/main/ExtPay.dev.js#L311
https://github.com/Glench/ExtPay/blob/main/ExtPay.dev.js#L315
Since these event names are pretty generic, someone can easily pick the same ones for their own events, making it possible that ExtPay picks up unintended events.
The text was updated successfully, but these errors were encountered: