Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issue with early return in subscribers hook implementation #88

Open
jhedstrom opened this issue May 24, 2017 · 0 comments
Open
Labels

Comments

@jhedstrom
Copy link
Collaborator

If this code in message_subscribe_message_subscribe_get_subscribers is ever triggered:

      if ($range) {
        --$range;
        if ($range == 0) {
          // We've reach the requested item.
          return $uids;
        }

it may cause issues when complex contexts are used, since in that event each entity type is looped through. If a user with a lower uid is subscribed to an entity that hasn't been processed when this exits early, that user would not be processed in subsequent queue runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant