Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[message_subscribe_ui] Take the flag status into account rather than picking up the first instance. #122

Open
codebymikey opened this issue May 2, 2023 · 0 comments · May be fixed by #123
Open

[message_subscribe_ui] Take the flag status into account rather than picking up the first instance. #122

codebymikey opened this issue May 2, 2023 · 0 comments · May be fixed by #123

Comments

@codebymikey
Copy link

There are several instances in the codebase where it makes use of flags irregardless of whether they're active or not. Their status should be taken into account.

e.g. https://github.com/Gizra/message_subscribe/blob/24710b9/message_subscribe_ui/src/Controller/SubscriptionController.php#L96-L97
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Take the flag status into account with the subscriptions. codebymikey/message_subscribe
1 participant
@codebymikey