Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted/active recipients flag #35

Open
adria0 opened this issue Apr 27, 2017 · 7 comments
Open

Deleted/active recipients flag #35

adria0 opened this issue Apr 27, 2017 · 7 comments

Comments

@adria0
Copy link

adria0 commented Apr 27, 2017

Consider to add a flag active in struct Recipient(like struct Spender) instead using activationTime == 0 as deletion flag

@jbaylina
Copy link
Contributor

It but it would take more gas...

@GriffGreen
Copy link
Member

GriffGreen commented Apr 27, 2017

gas optimization is something I want to do some time on this contract... i don't know if its best done now or after the first run of tests.... but low gas is a huge priority... mostly cause i think I will end up using these contracts a lot and am very cheap ;-)

@dipenjoshi
Copy link

i'm mostly worried about out of gas exceptions. being cheap on gas is 2nd priority.

@GriffGreen
Copy link
Member

I agree about the out of gas annoyances! This is something that mostly needs to be fixed in estimateGas() on the UI side, but it has been a big problem for us

@jbaylina
Copy link
Contributor

Here, the discusion is about "gas optimization" <-> "code readability" .

@adria0
Copy link
Author

adria0 commented Apr 27, 2017

Proposal:

  • Finish tests (& fix code bugs)
  • Make special tests only to check gas usage for specific scenarios (which ones?)
  • Make proposals for "gas optimization" <-> "code readability" equilibrium. Check changes against gas tests and then decide.

@GriffGreen
Copy link
Member

sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants