Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit-fixes #54

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Conversation

auryn-macmillan
Copy link

@auryn-macmillan auryn-macmillan commented Mar 22, 2022

This PR implements fixes for some minor issues identified in an audit.

  • removes jump at cliffTime
  • eliminates griefiing attack vector on changeAddress
  • implements tests for the proposed changes

@jfschwarz
Copy link

jfschwarz commented Mar 22, 2022

Cliff vesting plans, as commonly offered for stock options, usually have that "jump" when hitting the cliff. So I think the original implementation is more intuitive.

@auryn-macmillan
Copy link
Author

Cliff vesting plans, as commonly offered for stock options, usually have that "jump" when hitting the cliff. So I think the original implementation is more intuitive.

Yeah, after thinking about this more I actually think the original implementation is correct. initialAmount is just a somewhat novel feature that results in the potential for what is essentially two cliffs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants