Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Unsafe Serialization API to NSSecureCoding #236

Open
tmrff opened this issue Jul 25, 2023 · 1 comment
Open

Switch from Unsafe Serialization API to NSSecureCoding #236

tmrff opened this issue Jul 25, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@tmrff
Copy link

tmrff commented Jul 25, 2023

We use the GIPHY iOS xcframework within an iOS app. We recently performed a security scan using Datatherom. The scan results reported that the GIPHY framework contains code that leverages NSCoding, which is known to be vulnerable to object substitution attacks.

The scan revealed that the _TtC10GiphyUISDK11GPHCategory class in the binary conforms to NSCoding.

The NSCoding protocol is not a recommended approach for secure coding. Apple itself suggests using NSSecureCoding instead, which helps to ensure that the serialized and deserialized instances are of the same class.

Please consider migrating to NSSecureCoding if it's feasible.

@tmrff tmrff added the enhancement New feature or request label Jul 25, 2023
@cgmaier
Copy link
Contributor

cgmaier commented Oct 19, 2023

hey @ThomasR39 sorry for the late reply here. Thanks for getting this on our radar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants