Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalyst - Failing to Distribute #194

Open
fishandphil opened this issue Feb 20, 2022 · 5 comments
Open

Catalyst - Failing to Distribute #194

fishandphil opened this issue Feb 20, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@fishandphil
Copy link

Good afternoon

We use the GIPHY iOS xcframework within an iOS app. Everything works as expected, we are able to compile, run, archive, upload to App Store Connected. We have the same version of that app on macOS thanks to Catalyst. We can compile, run, archive but not upload to App Store Connect because of the GIPHY xcframework.

Screenshot 2022-02-20 at 17 57 37

What is your recommendation? Can anyone distribute on Catalyst?

Here is the error from the log:

`2022-02-20 16:53:40 +0000 Failed to generate distribution items with error: Error Domain=IDEFoundationErrorDomain Code=1 "/Users/xxx/Library/Developer/Xcode/Archives/2022-02-20/xxx 20-02-2022, 17.10.xcarchive/Products contains invalid products." UserInfo={NSLocalizedDescription=/Users/xxx/Library/Developer/Xcode/Archives/2022-02-20/xxx 20-02-2022, 17.10.xcarchive/Products contains invalid products., NSLocalizedRecoverySuggestion=Multiple binaries share the same codesign path:
/Applications/xxx.app/Contents/Frameworks/GiphyUISDK.framework/Versions/Current

Binaries:
/Applications/xxx.app/Contents/Frameworks/GiphyUISDK.framework/Versions/Current/GiphyUISDK
/Applications/xxx.app/Contents/Frameworks/GiphyUISDK.framework/GiphyUISDK

This can happen if your build process copies frameworks by following symlinks. }`

Thanks a lot. We'd love to distribute our Catalyst app with the GIPHY features enabled.

@fishandphil fishandphil added the bug Something isn't working label Feb 20, 2022
@fishandphil
Copy link
Author

Anyone at GIPHY can comment on this?

@cgmaier
Copy link
Contributor

cgmaier commented Mar 9, 2022

hey @fishandphil thanks for opening this issue - we've done some initial investigation but haven't yet resolved. we did notice some issues when archiving if the SDK is imported via CocoaPods, whereas things seemed to work fine when imported with SPM.

@fishandphil
Copy link
Author

fishandphil commented Mar 10, 2022

Thank you very much for the update @cgmaier!
We've imported the xcframework via CocoaPods. So that in-line with your statement.

I have no idea what SPM is?

I see that you've added a GIPHYUISDK.xcframework within the repo itself? Should we try that instead?

Personally, I really like the approach that Firebase or RevenueCat take, you can download the archived xcframework directly from their release page. It is convenient.
Example:
https://github.com/RevenueCat/purchases-ios/releases
https://github.com/firebase/firebase-ios-sdk/releases/tag/v8.13.0

Thank you

@cgmaier
Copy link
Contributor

cgmaier commented Mar 10, 2022

hey @fishandphil you're welcome to download the archived xcframework from this repo and use it in a similar fashion, though you'd also have to ensure you link in libwebp which the GIPHY SDK depends on - Swift Package Manager (SPM) does this automatically.

highly recommend checking out SPM! it's a really convenient way of managing dependencies and integrates natively into Xcode.

given all the new architectures added in the past few years and all the changes to framework structure, it seems that a native Apple solution is somewhat necessary to make sure all the architectures/build settings place nice together

we'll keep doing our best to support CocoaPods but want to encourage developers to adopt SPM as a best practice for integrating GIPHY on iOS

@fishandphil
Copy link
Author

Dear @cgmaier

Thank you for your reply.

Our product is still fully written in obj-c, so unclear if the SPM makes sense.

We tried your xcframework embedded in the repository for our Catalyst app

Big minus: every time we run our product on our own macOS device from Xcode. We get the attached pop-up which is very annoying.
Screenshot 2022-03-15 at 20 27 05

Big bonus: it does archive & upload to App Store Connect.

Would be great to have that error removed 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants