Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Swift, GiphyYYAnimatedImageView's image doesn't explicitly conform to GiphyYYAnimatedImage #157

Open
jscalo opened this issue May 17, 2021 · 0 comments
Open

In Swift, GiphyYYAnimatedImageView's image doesn't explicitly conform to GiphyYYAnimatedImage #157

jscalo opened this issue May 17, 2021 · 0 comments

Comments

@jscalo
Copy link

jscalo commented May 17, 2021 •
edited
Loading

In Swift, GiphyYYAnimatedImageView.image is not explicitly declared to conform to the GiphyYYAnimatedImage protocol. The result is that trying to get the duration of a frame from GiphyYYAnimatedImageView is pretty unintuitive.

GiphyYYAnimatedImageView.image.animatedImageDuration(at:) doesn't work. Instead you'd need to do GiphyYYAnimatedImageView.image as? GiphyYYAnimatedImage.animatedImageDuration(at:) which is cumbersome and perhaps not obvious.

iOS SDK v2.1.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jscalo