Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Picker does not set $dirty #13

Open
bjarnef opened this issue Mar 9, 2016 · 4 comments
Open

Link Picker does not set $dirty #13

bjarnef opened this issue Mar 9, 2016 · 4 comments

Comments

@bjarnef
Copy link

bjarnef commented Mar 9, 2016

It seems that Link Picker does not set $dirty, when you choose a node (or enter a link) (making the "unsaved changed" dialog pop up when you navigate to another node without saving changes).

It is also an issue with MNTP: http://issues.umbraco.org/issue/U4-8143

@karltynan
Copy link
Contributor

What version of Umbraco are you seeing this on?

@bjarnef
Copy link
Author

bjarnef commented Mar 21, 2016

@karltynan
Copy link
Contributor

Interesting that I don't get the pop up on 7.4.0.

So the intention is to show the pop up if you have made changes and not saved, and not to show it if you haven't made an changes.

I will look into adding this functionality for the next version.

@bjarnef
Copy link
Author

bjarnef commented Mar 21, 2016

Yep, that is how the popup is intended - it show up when a property form has dirty property set to true. You should be able to see a ng-dirty class on the form, when you have made a change.

But I think it is an issue for Content Picker / MNTP as well:
http://issues.umbraco.org/issue/U4-8143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@karltynan @bjarnef and others