Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement JFR profiler on the "geyser" command for standalone. #5053

Open
PedroMPagani opened this issue Sep 21, 2024 · 3 comments
Open

Implement JFR profiler on the "geyser" command for standalone. #5053

PedroMPagani opened this issue Sep 21, 2024 · 3 comments
Labels
Feature Request A feature request. Waiting On Response When an issue or PR is waiting on a response from a [specific] person.

Comments

@PedroMPagani
Copy link

What feature do you want to see added?

This will 100% def help improving memory usage and CPU usage of geyser, and possibly even help solving other issues.
I think this, along maybe another implementation for a hprof are both benefitial.

Are there any alternatives?

Only through extensions

@PedroMPagani PedroMPagani added the Feature Request A feature request. label Sep 21, 2024
@onebeastchris
Copy link
Member

onebeastchris commented Sep 21, 2024

Why not just use the geyser spark extension for profiling?
The whole point of extensions is to be able to add functionality that is useful, but not necessarily vital enough to be added directly into Geyser itself.

@onebeastchris onebeastchris added the Waiting On Response When an issue or PR is waiting on a response from a [specific] person. label Sep 21, 2024
@PedroMPagani
Copy link
Author

PedroMPagani commented Sep 21, 2024

A JFR profiler records both ways(Memory alloc and CPU usage), has a LOT less overhead than a spark extension, and it's much easier to read/use for investigate?
you can see a lot more stuff than a spark profiler, you can see garbage collector, number of active threads, different events like parking, etc, while on spark you're not going to see much.

@onebeastchris
Copy link
Member

onebeastchris commented Sep 26, 2024

lot less overhead

Got some data for that?

I'll be honest, so far, spark has been beneficial enough to the point where I don't see the need to add a built-in profiler that barely anyone would use. That would be extension territory. Open to hear what others think, but, this seems like a tad out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request A feature request. Waiting On Response When an issue or PR is waiting on a response from a [specific] person.
Projects
None yet
Development

No branches or pull requests

2 participants