We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let's change signature of the flow description in such way to explicitly define dependencies, arguments and return values.
Description is based on test SimpleWIthDependencies. Flow A is described in effe.go. It implicitly defines:
A
NewAImpl
AFunc
Implicitly means that none of the above is defined in effe.go, but generates by cli tool. And reader of effe.go file doesn't understand what they are.
I propose to change signature of flow function to be
func MyFLow([dependencies...]) func([arguments...]) [return values...] { effe.BuildFlow(...) return nil }
So instead of generation signatures of NewAImpl and AFunc generator will just check that they match flow description.
Test SimpleWIthDependencies will be changed. FIles steps.go and effe_gen.go will remain the same. File effe.go will be changed to
func A(UserRepository, NotificationRepository) func(string) error { effe.BuildFlow( effe.Step(step1), effe.Step(step2), ) return nil }
from
effe/testdata/SimpleWIthDependencies/foo/effe.go
Lines 7 to 13 in d8f24ab
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Summary
Let's change signature of the flow description in such way to explicitly define dependencies, arguments and return values.
Description
Description is based on test SimpleWIthDependencies.
Flow
A
is described in effe.go.It implicitly defines:
NewAImpl
AFunc
AFunc
Implicitly means that none of the above is defined in effe.go, but generates by cli tool.
And reader of effe.go file doesn't understand what they are.
I propose to change signature of flow function to be
So instead of generation signatures of
NewAImpl
andAFunc
generator will just check that they match flow description.Example
Test SimpleWIthDependencies will be changed.
FIles steps.go and effe_gen.go will remain the same.
File effe.go will be changed to
from
effe/testdata/SimpleWIthDependencies/foo/effe.go
Lines 7 to 13 in d8f24ab
The text was updated successfully, but these errors were encountered: