From 384d1e462de0622ee4d3f1a68bc95ba72b1e1c14 Mon Sep 17 00:00:00 2001 From: Pol Quintana Date: Wed, 31 Aug 2022 16:00:01 +0200 Subject: [PATCH 1/2] Move 'old SDK' regression to 13 --- .github/workflows/smoke-checks.yml | 20 ++++++++++--------- .../ChannelController_Tests.swift | 8 ++++---- 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/.github/workflows/smoke-checks.yml b/.github/workflows/smoke-checks.yml index 1b2e31b9a39..8758ff0d01b 100644 --- a/.github/workflows/smoke-checks.yml +++ b/.github/workflows/smoke-checks.yml @@ -164,25 +164,27 @@ jobs: run: echo "::set-output name=launch_id::${{env.LAUNCH_ID}}" if: env.LAUNCH_ID != '' - build-xcode12: - name: Build LLC + UI (Xcode 12) - runs-on: macos-11 + build-xcode13: + name: Build LLC + UI (Xcode 13) + runs-on: macos-12 if: ${{ github.event_name != 'push' }} steps: - uses: actions/checkout@v2 - uses: ./.github/actions/bootstrap - - name: Build LLC (Xcode 12) - run: bundle exec fastlane test device:"iPhone 12" build_for_testing:true + - name: List Xcode versions xcversion sees + run: mdfind "kMDItemCFBundleIdentifier = 'com.apple.dt.Xcode'" + - name: Build LLC (Xcode 13) + run: bundle exec fastlane test device:"iPhone 13" build_for_testing:true timeout-minutes: 25 env: - XCODE_VERSION: "12.5.1" + XCODE_VERSION: "13" GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} GITHUB_EVENT: ${{ toJson(github.event) }} - - name: Build UI (Xcode 12) - run: bundle exec fastlane test_ui device:"iPhone 12" build_for_testing:true + - name: Build UI (Xcode 13) + run: bundle exec fastlane test_ui device:"iPhone 13" build_for_testing:true timeout-minutes: 25 env: - XCODE_VERSION: "12.5.1" + XCODE_VERSION: "13" GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} GITHUB_EVENT: ${{ toJson(github.event) }} diff --git a/Tests/StreamChatTests/Controllers/ChannelController/ChannelController_Tests.swift b/Tests/StreamChatTests/Controllers/ChannelController/ChannelController_Tests.swift index f9949e0fcde..af0fd55d0d0 100644 --- a/Tests/StreamChatTests/Controllers/ChannelController/ChannelController_Tests.swift +++ b/Tests/StreamChatTests/Controllers/ChannelController/ChannelController_Tests.swift @@ -2170,8 +2170,8 @@ final class ChannelController_Tests: XCTestCase { waitForExpectations(timeout: 0.1) - let paginatonParameter = env.channelUpdater?.update_channelQuery?.pagination?.parameter - guard case let .lessThan(paginationMessageId) = paginatonParameter else { + let paginationParameter = env.channelUpdater?.update_channelQuery?.pagination?.parameter + guard case let .lessThan(paginationMessageId) = paginationParameter else { XCTFail("Missing pagination parameter") return } @@ -2212,8 +2212,8 @@ final class ChannelController_Tests: XCTestCase { waitForExpectations(timeout: 0.1) - let paginatonParameter = env.channelUpdater?.update_channelQuery?.pagination?.parameter - guard case let .lessThan(paginationMessageId) = paginatonParameter else { + let paginationParameter = env.channelUpdater?.update_channelQuery?.pagination?.parameter + guard case let .lessThan(paginationMessageId) = paginationParameter else { XCTFail("Missing pagination parameter") return } From f89f6fbd3b5df90379f7b32cdc5a9918084268e7 Mon Sep 17 00:00:00 2001 From: Pol Quintana Date: Wed, 31 Aug 2022 16:00:21 +0200 Subject: [PATCH 2/2] Disable Xcode 13 regression until Xcode 14 is used --- .github/workflows/smoke-checks.yml | 46 +++++++++++++++--------------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/.github/workflows/smoke-checks.yml b/.github/workflows/smoke-checks.yml index 8758ff0d01b..1d518e7b81e 100644 --- a/.github/workflows/smoke-checks.yml +++ b/.github/workflows/smoke-checks.yml @@ -164,29 +164,29 @@ jobs: run: echo "::set-output name=launch_id::${{env.LAUNCH_ID}}" if: env.LAUNCH_ID != '' - build-xcode13: - name: Build LLC + UI (Xcode 13) - runs-on: macos-12 - if: ${{ github.event_name != 'push' }} - steps: - - uses: actions/checkout@v2 - - uses: ./.github/actions/bootstrap - - name: List Xcode versions xcversion sees - run: mdfind "kMDItemCFBundleIdentifier = 'com.apple.dt.Xcode'" - - name: Build LLC (Xcode 13) - run: bundle exec fastlane test device:"iPhone 13" build_for_testing:true - timeout-minutes: 25 - env: - XCODE_VERSION: "13" - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - GITHUB_EVENT: ${{ toJson(github.event) }} - - name: Build UI (Xcode 13) - run: bundle exec fastlane test_ui device:"iPhone 13" build_for_testing:true - timeout-minutes: 25 - env: - XCODE_VERSION: "13" - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - GITHUB_EVENT: ${{ toJson(github.event) }} + # build-xcode13: + # name: Build LLC + UI (Xcode 13) + # runs-on: macos-12 + # if: ${{ github.event_name != 'push' }} + # steps: + # - uses: actions/checkout@v2 + # - uses: ./.github/actions/bootstrap + # - name: List Xcode versions xcversion sees + # run: mdfind "kMDItemCFBundleIdentifier = 'com.apple.dt.Xcode'" + # - name: Build LLC (Xcode 13) + # run: bundle exec fastlane test device:"iPhone 13" build_for_testing:true + # timeout-minutes: 25 + # env: + # XCODE_VERSION: "13" + # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + # GITHUB_EVENT: ${{ toJson(github.event) }} + # - name: Build UI (Xcode 13) + # run: bundle exec fastlane test_ui device:"iPhone 13" build_for_testing:true + # timeout-minutes: 25 + # env: + # XCODE_VERSION: "13" + # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + # GITHUB_EVENT: ${{ toJson(github.event) }} build-apps: name: Build Sample + Demo Apps