From 86abebffa5c4ab1d09c2bdbae6765d8421bd4f21 Mon Sep 17 00:00:00 2001 From: Pol Quintana Date: Wed, 31 Aug 2022 16:29:57 +0200 Subject: [PATCH] [Internal] Move Old SDK tests to 13 - Currently disabled (#2262) * Move 'old SDK' regression to 13 * Disable Xcode 13 regression until Xcode 14 is used --- .github/workflows/smoke-checks.yml | 44 ++++++++++--------- .../ChannelController_Tests.swift | 8 ++-- 2 files changed, 27 insertions(+), 25 deletions(-) diff --git a/.github/workflows/smoke-checks.yml b/.github/workflows/smoke-checks.yml index 1b2e31b9a39..1d518e7b81e 100644 --- a/.github/workflows/smoke-checks.yml +++ b/.github/workflows/smoke-checks.yml @@ -164,27 +164,29 @@ jobs: run: echo "::set-output name=launch_id::${{env.LAUNCH_ID}}" if: env.LAUNCH_ID != '' - build-xcode12: - name: Build LLC + UI (Xcode 12) - runs-on: macos-11 - if: ${{ github.event_name != 'push' }} - steps: - - uses: actions/checkout@v2 - - uses: ./.github/actions/bootstrap - - name: Build LLC (Xcode 12) - run: bundle exec fastlane test device:"iPhone 12" build_for_testing:true - timeout-minutes: 25 - env: - XCODE_VERSION: "12.5.1" - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - GITHUB_EVENT: ${{ toJson(github.event) }} - - name: Build UI (Xcode 12) - run: bundle exec fastlane test_ui device:"iPhone 12" build_for_testing:true - timeout-minutes: 25 - env: - XCODE_VERSION: "12.5.1" - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - GITHUB_EVENT: ${{ toJson(github.event) }} + # build-xcode13: + # name: Build LLC + UI (Xcode 13) + # runs-on: macos-12 + # if: ${{ github.event_name != 'push' }} + # steps: + # - uses: actions/checkout@v2 + # - uses: ./.github/actions/bootstrap + # - name: List Xcode versions xcversion sees + # run: mdfind "kMDItemCFBundleIdentifier = 'com.apple.dt.Xcode'" + # - name: Build LLC (Xcode 13) + # run: bundle exec fastlane test device:"iPhone 13" build_for_testing:true + # timeout-minutes: 25 + # env: + # XCODE_VERSION: "13" + # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + # GITHUB_EVENT: ${{ toJson(github.event) }} + # - name: Build UI (Xcode 13) + # run: bundle exec fastlane test_ui device:"iPhone 13" build_for_testing:true + # timeout-minutes: 25 + # env: + # XCODE_VERSION: "13" + # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + # GITHUB_EVENT: ${{ toJson(github.event) }} build-apps: name: Build Sample + Demo Apps diff --git a/Tests/StreamChatTests/Controllers/ChannelController/ChannelController_Tests.swift b/Tests/StreamChatTests/Controllers/ChannelController/ChannelController_Tests.swift index f9949e0fcde..af0fd55d0d0 100644 --- a/Tests/StreamChatTests/Controllers/ChannelController/ChannelController_Tests.swift +++ b/Tests/StreamChatTests/Controllers/ChannelController/ChannelController_Tests.swift @@ -2170,8 +2170,8 @@ final class ChannelController_Tests: XCTestCase { waitForExpectations(timeout: 0.1) - let paginatonParameter = env.channelUpdater?.update_channelQuery?.pagination?.parameter - guard case let .lessThan(paginationMessageId) = paginatonParameter else { + let paginationParameter = env.channelUpdater?.update_channelQuery?.pagination?.parameter + guard case let .lessThan(paginationMessageId) = paginationParameter else { XCTFail("Missing pagination parameter") return } @@ -2212,8 +2212,8 @@ final class ChannelController_Tests: XCTestCase { waitForExpectations(timeout: 0.1) - let paginatonParameter = env.channelUpdater?.update_channelQuery?.pagination?.parameter - guard case let .lessThan(paginationMessageId) = paginatonParameter else { + let paginationParameter = env.channelUpdater?.update_channelQuery?.pagination?.parameter + guard case let .lessThan(paginationMessageId) = paginationParameter else { XCTFail("Missing pagination parameter") return }