From 7bfa7f1ee4614658b957c9e3f5cd77ff921e6f0c Mon Sep 17 00:00:00 2001 From: Vishal Narkhede Date: Fri, 5 Mar 2021 17:28:23 +0100 Subject: [PATCH 1/3] Update README.md --- README.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/README.md b/README.md index 9514be5..b82f04e 100644 --- a/README.md +++ b/README.md @@ -2,8 +2,6 @@ > React Native components to create activity and notification feeds using Stream -> 🎉 [v1.0.1](https://github.com/GetStream/react-native-activity-feed/releases/tag/v1.0.1) supports Expo 40 and react-native 0.63 🎉 - [![NPM](https://img.shields.io/npm/v/react-native-activity-feed.svg)](https://www.npmjs.com/package/react-native-activity-feed) [![Build Status](https://travis-ci.org/GetStream/react-native-activity-feed.svg?branch=master)](https://travis-ci.org/GetStream/react-native-activity-feed) [![Component Reference](https://img.shields.io/badge/docs-component%20reference-blue.svg)](https://getstream.github.io/react-native-activity-feed/) From b0c480ad3b73a39b86edbb2049024cbe33d8f473 Mon Sep 17 00:00:00 2001 From: Amin Mahboubi Date: Thu, 8 Apr 2021 12:57:59 +0200 Subject: [PATCH 2/3] close faye connection on app unmount --- src/Context/StreamApp.js | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/Context/StreamApp.js b/src/Context/StreamApp.js index 61bf063..f1cea61 100644 --- a/src/Context/StreamApp.js +++ b/src/Context/StreamApp.js @@ -133,6 +133,13 @@ export class StreamApp extends React.Component { this.setState({ t, tDateTimeParser }); } + componentWillUnmount() { + const client = this.state.client; + if (client && client.fayeClient) { + client.fayeClient.disconnect(); + } + } + render() { if (!this.state.t) return null; From 706057192c2ea36835e27b07e722b35e7a3d2ba8 Mon Sep 17 00:00:00 2001 From: Vishal Narkhede Date: Fri, 9 Apr 2021 10:24:48 +0200 Subject: [PATCH 3/3] fixed propType for NewActivitiesNotification component (#177) --- src/components/NewActivitiesNotification.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/NewActivitiesNotification.js b/src/components/NewActivitiesNotification.js index 256de2f..dc20607 100644 --- a/src/components/NewActivitiesNotification.js +++ b/src/components/NewActivitiesNotification.js @@ -78,7 +78,7 @@ class NewActivitiesNotification extends React.Component { NewActivitiesNotification.propTypes = { adds: PropTypes.arrayOf(PropTypes.object), - deletes: PropTypes.arrayOf(PropTypes.object), + deletes: PropTypes.arrayOf(PropTypes.string), labelSingular: PropTypes.string, labelPlural: PropTypes.string, /**