Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow FeedManager methods to accept activity type Activity | EnrichedActivity #303

Open
MartinCupela opened this issue Sep 24, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@MartinCupela
Copy link
Collaborator

FeedManager methods that accept activity as argument expect it to be of type Activity and not EnrichedActivity. On the other hand, the react-activity-feed components are working always with EnrichedActivity objects and that leads to type conflict when calling e.g. feed.onAddReaction inside the component. However these FeedManager methods could accept EnrichedActivity as well, without causing any issues executing the API calls. The proposed solution is to change the activity arg type to activity: Activity | EnrichedActivity. This should not lead to any breaking changes.

image (1)
image
.

@arnautov-anton arnautov-anton added the enhancement New feature or request label Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants