Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve information contacts for GDPRDisclaimer #1064

Open
bruhnild opened this issue Mar 7, 2024 · 2 comments
Open

Improve information contacts for GDPRDisclaimer #1064

bruhnild opened this issue Mar 7, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@bruhnild
Copy link
Contributor

bruhnild commented Mar 7, 2024

For now to complete GDPRDisclaimer, we use information from contact's footer.

In order to add another name, or email address it could be usefull to create explicit settings for these.

const { contact: { name, number = '', mail } = {} } = getFooterConfig();
<p className="text-sm text-italic">
<FormattedMessage
  id={'report.GDPRDisclaimer'}
  values={{
    b: () => <strong className="font-bold">{name}</strong>,
    a: () => (
      <a
        className="underline"
        href={mail !== undefined ? `mailto:${mail}` : `tel:${number}`}
      >
        {mail ?? number}
      </a>
    ),
  }}
/>
</p>
@bruhnild bruhnild added the enhancement New feature or request label Mar 7, 2024
@babastienne
Copy link
Member

babastienne commented Mar 7, 2024

The problem is not when we try to use other name or contact, but whenever we try to add some text in bold (<b>) or a link (<a>) it is override with informations from the footer, which can be annoying and mostly is not documented anywhere so it seems like a bug to someone who don't look at the code.

@dtrucs
Copy link
Collaborator

dtrucs commented Mar 8, 2024

By adding a property to the settings such as:

GDPRDisclaimer: {
  organisms: string[],
  email: string[]
}

And specify in the documentation that if this prop is not provided, the application will retrieve the information from the contact's footer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants