Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump django-tinymce from 3.5.0 to 4.1.0 #4210

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 2, 2024

Bumps django-tinymce from 3.5.0 to 4.1.0.

Release notes

Sourced from django-tinymce's releases.

4.1.0

What's Changed

New Contributors

Full Changelog: jazzband/django-tinymce@4.0.0...4.1.0

4.0.0

  • Upgrade embedded TinyMCE from 5.10.7 to 6.8.3

The spellchecker plugin is gone (including USE_SPELLCHECKER setting). Use the browser_spellcheck TinyMCE option (activated by default) to enable browser-based spellchecking.

Changelog

Sourced from django-tinymce's changelog.

Changelog #########

This document describes changes between each past release.

4.0.1 (2024-06-21)

  • Upgrade embedded TinyMCE from 6.8.3 to 6.8.4
  • Renamed toolbar elements (namely formatselect is now blocks) to follow TinyMCE 6 renames. Also removed from the docs examples some buttons only available through paid subscriptions (#470).

4.0.0 (2024-03-27)

  • Upgrade embedded TinyMCE from 5.10.7 to 6.8.3

The spellchecker plugin is gone (including USE_SPELLCHECKER setting). Use the browser_spellcheck TinyMCE option (activated by default) to enable browser-based spellchecking.

3.7.1 (2024-02-06)

  • Reintroduce the MANIFEST.in file to properly build the package. Release 3.7.0 on PyPI was unusable (#454).

3.7.0 (2024-02-06)

  • Drop support for Django 2.2, 4.0, and 4.1.
  • Add support for Django 4.2 and 5.0.
  • Drop support for Python 3.7 and add support for Python 3.11 and 3.12.
  • New pyproject.toml replaces the legacy setup.py project config.
  • Use staticfiles storage API to find tinymce location (#420). It was already done in 3.6.0, but had to be reverted in 3.6.1 (see #430).
  • Fixed selector usage for elements with __prefix__ (typically inlines).
  • TINYMCE_JS_ROOT setting has been removed.

3.6.1 (2023-03-20)

  • Fixed a regression by reverting usage of staticfiles to find tinymce location (#420, #430).

3.6.0 (2023-03-18)

  • Upgrade embedded tinyMCE from 5.10.1 to 5.10.7

... (truncated)

Commits
  • dc64876 Prepare release 4.1.0
  • 4c4dd93 Upgraded TinyMCE to 6.8.4
  • d57a92c [pre-commit.ci] pre-commit autoupdate
  • e79415d Refs #470 - Removed buttons from premium plugins in the docs.
  • fb7b263 Refs #470 - Replaced toolbar elements renamed in TinyMCE 6
  • 87648e8 Remove plugin "code" mentioned twice
  • eac5cc3 Upgrade version in pyproject.toml
  • dc270e1 Prepare release 4.0.0
  • 54d64ba Fixes #460 - Remove sourceMappingURL lines from tinymce static files
  • f04e1c8 Migrate from TinyMCE 5 to TinyMCE 6
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jul 2, 2024
Copy link

cypress bot commented Jul 2, 2024

Geotrek-admin    Run #10491

Run Properties:  status check passed Passed #10491  •  git commit 3013e83371 ℹ️: Merge f72bfa0fe6b9da60cd8fdd5facee15f4a2965712 into 7e34d79a19458d4223220d3b863c...
Project Geotrek-admin
Branch Review refs/pull/4210/merge
Run status status check passed Passed #10491
Run duration 02m 06s
Commit git commit 3013e83371 ℹ️: Merge f72bfa0fe6b9da60cd8fdd5facee15f4a2965712 into 7e34d79a19458d4223220d3b863c...
Committer dependabot[bot]
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

@submarcos
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/pip/django-tinymce-4.1.0 branch from 735cf89 to 0ac2bb3 Compare November 26, 2024 12:44
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.45%. Comparing base (7e34d79) to head (f72bfa0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4210   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files         267      267           
  Lines       21106    21106           
=======================================
  Hits        20780    20780           
  Misses        326      326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcantoinedupre
Copy link
Contributor

👋 this django-tinymce upgrade also bumps the TinyMCE major version. I don't think we have e2e tests on the TinyMCE form fields and I expect major changes with TinyMCE objects APIs. We should test this in a separate branch before upgrading.

@submarcos
Copy link
Member

submarcos commented Nov 29, 2024

@marcantoinedupre Thank you

I test in local environement

No visual difference with default Tiny mce fields in admin
No visual difference with complex flatpage content with pictures but in console:

  • tinymce.min.js:4 Invalid value passed for the newline_behavior option. Must be one of: block, linebreak, invert or default (in config there is empty '' value. change to default ?
  • In previous version, there is console log that says imagetools will be a premium plugin in next version, so we need to disable it. It seems to be tools to resize / shrink / crop image in web ui (https://www.tiny.cloud/docs/tinymce/5/editimage/)

dependabot bot and others added 2 commits November 29, 2024 11:55
Bumps [django-tinymce](https://github.com/jazzband/django-tinymce) from 3.5.0 to 4.1.0.
- [Release notes](https://github.com/jazzband/django-tinymce/releases)
- [Changelog](https://github.com/jazzband/django-tinymce/blob/master/CHANGELOG.rst)
- [Commits](jazzband/django-tinymce@3.5.0...4.1.0)

---
updated-dependencies:
- dependency-name: django-tinymce
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@submarcos submarcos force-pushed the dependabot/pip/django-tinymce-4.1.0 branch from 676a1ed to e783fcf Compare November 29, 2024 10:55
@dtrucs
Copy link
Contributor

dtrucs commented Nov 29, 2024

* In previous version, there is console log that says imagetools will be a premium plugin in next version, so we need to disable it. It seems to be tools to resize / shrink / crop image in web ui (https://www.tiny.cloud/docs/tinymce/5/editimage/)

The use of image-tools is perhaps a little superfluous, but if it's essential for the community it should be possible to add a library like cropperjs as a replacement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants