New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if(!is.null(min_event_temp)) will never be false #11

Open

snhing opened this issue Oct 23, 2019 · 0 comments

snhing commented Oct 23, 2019

When min_event_temp is set to NULL, it is then turned into a numeric value, as.numeric(min_event_temp), so !is.null(min_event_temp) is always true.

sumsarizer/R/event_detectors.R

Line 21 in d9a7533

min_event_temp <- as.numeric(min_event_temp)

sumsarizer/R/event_detectors.R

Line 80 in d9a7533

if(!is.null(min_event_temp)){

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment