Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

End-of-event padding can cause events to overlap #10

Open
daterdots opened this issue Oct 21, 2019 · 1 comment
Open

End-of-event padding can cause events to overlap #10

daterdots opened this issue Oct 21, 2019 · 1 comment
Assignees
@ajaypillarisetti @hbenkhay

Comments

@daterdots
Copy link
Member

This line can cause events that are close together to overlap:

sumsarizer/R/events.R

Line 54 in d9a7533

stop_time = max((timestamp + sample_interval), na.rm = T),

This seems to happen especially when the min_break_sec is small.
@daterdots
Copy link
Member Author

@ajaypillarisetti I think this is why we're seeing this kind of stuff:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajaypillarisetti ajaypillarisetti

@hbenkhay hbenkhay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ajaypillarisetti @daterdots @hbenkhay