Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting a new script has a chance to throw a "Unable to aquire writer lock" error, which can occasionally crash the client itself. #7

Open
hubConnect opened this issue Dec 29, 2021 · 5 comments

Comments

@hubConnect
Copy link

No description provided.

@scottr1634
Copy link
Collaborator

I'm seeing this issue as well, especially when a script launches another script.

@hubConnect
Copy link
Author

I've definitely also seen this mostly in the cases of scripts starting other scripts.

Seems like this one is on the form itself and is probably related to merging the two lists together
https://github.com/GenieClient/genie3/blob/main/Forms/FormMain.cs#L3003

@hubConnect
Copy link
Author

I wonder though, if the UI freeze itself could actually be related to the way that Genie is handling exceptions in general?

@scottr1634
Copy link
Collaborator

Exceptions tend to be expensive in general, looks like c# is no, uh, exception:

"exceptions are at least 30,000 times slower than return codes" - source

@scottr1634
Copy link
Collaborator

Quick note that I can actually replicate this behavior in the original genie client if I launch scripts from scripts using put .myscript but not when using send .myscript. But in our fork, I'm seeing the issue with send .myscript as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants