Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IGRINS cleanup #31

Open
phirstgemini opened this issue May 24, 2024 · 0 comments
Open

IGRINS cleanup #31

phirstgemini opened this issue May 24, 2024 · 0 comments
Assignees
Milestone

Comments

@phirstgemini
Copy link
Collaborator

The DRAGONS igrins adclass.py is a mess.
The whole PHU vs 1st extension thing appears to be because the existing S files have a completely empty (ie not even an INSTRUME header) PHU and everything is in the extension. Or are they single ext FITS and this is what astrodata makes of them?

Not clear what headers have changed over time, this will need some trial and error to clean up. Now that there's no more data, it might be better to fix the data files rather than kludge it in the code.

At this point, there's basically nothing in the IGRINS-2 team's adclass.py. Not obvious if they should use the same class, or if one should be a subclass of the other. Perhaps IGRINS should be a subclass of IGRINS-2, so that when they actually handle actual instrument stuff in the -2 one then the old one will get it, and we can handle the quirks of the visitor instrument file format in the subclass.

@phirstgemini phirstgemini self-assigned this May 24, 2024
@phirstgemini phirstgemini added this to the 3.3 release milestone Sep 5, 2024
@phirstgemini phirstgemini modified the milestones: 3.3 release, 3.x release Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant