Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Code Formatting Breaks Java import Orderings #5

Open
gkapfham opened this issue Oct 24, 2019 · 2 comments
Open

Java Code Formatting Breaks Java import Orderings #5

gkapfham opened this issue Oct 24, 2019 · 2 comments
Assignees

Comments

@gkapfham
Copy link
Collaborator

I wanted to report that I checked the automated reformatting tool with some other Java code (i.e., code that is not in this repository) and I discovered that it breaks imports like these:

import labsix.checker.PasswordChecker;
import labsix.data.ResultsTable;

import java.util.Random;

My understanding is that you should not mix imports from programmer-defined Java classes with those that are a part of the standard Java library. However, the import tool does do this for the sample projects that I tried.

Can you confirm that this is a problem? Can you think of a workaround? If not, then we may need to either remove the tool from this sample repository. What do you think @corlettim and @schultzh?

@corlettim
Copy link
Contributor

I believe I am seeing the same errors with this issue. I am not sure of a workaround but I am going to investigate a little bit more on this! I will let you know more once I experiment @gkapfham !

@gkapfham
Copy link
Collaborator Author

Thanks for investigating this issue @corlettim. I think that this would be the easiest to replicate with a different example, perhaps one that contains multiple Java classes, some of which that are imported by the other Java classes. Let me know what you find, okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants