-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue#33 ~ Documentation Website #89
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
=======================================
Coverage 92.09% 92.09%
=======================================
Files 6 6
Lines 253 253
=======================================
Hits 233 233
Misses 20 20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure your branch is up to date with the master branch before the reviews.
Hi @kailaniwoodard, thanks for working on this feature that creates a documentation website for the tool. Before reviewing, I'm just curious if the website is currently being deployed on any platforms? I think it would be easier if reviewers can just go check out the website instead of building and serving it locally. |
@enpuyou I'm currently attempting to deploy the website using Netlify as of right now, but I'm having some trouble so right now it's a bit up in the air. |
Hello! Thanks for all the work on this PR. Please let us know if you need any help or if it's ready for review. |
This PR is ready for review. Thank you |
@enpuyou @noorbuchi @corlettim |
@waryankaa it looks like netlify deployment is failing. Have you been able to figure out why this is happening and if it is feasible to fix it? |
* Export code from https://github.com/umdjs/umd/blob/master/returnExports.js | ||
*/ | ||
;(function (root, factory) { | ||
if (typeof define === 'function' && define.amd) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Strings must use doublequote.
if (typeof define === 'function' && define.amd) { | |
if (typeof define === "function" && define.amd) { |
For this pull request, we have created a website that will explain the features of GatorMiner
What is the current behavior?
The current behavior is that we have created a website interface and we will continue to work on adding the information about the different parts.
What is the new behavior if this PR is merged?
A new website will be added containing detailed information about the GatorMiner functions.
Close #33
Type of change
Please describe the pull request as one of the following:
Other information
This PR has:
Developers
@kailaniwoodard @Peter-Snipes @zaethovenn @waryankaa