diff --git a/kernels/portable/test/targets.bzl b/kernels/portable/test/targets.bzl index ae0dbaef40d..261ec50d761 100644 --- a/kernels/portable/test/targets.bzl +++ b/kernels/portable/test/targets.bzl @@ -8,7 +8,7 @@ def define_common_targets(): """ define_supported_features_lib() - op_test(name = "op_allclose_test", aten_compatible = False) + op_test(name = "op_allclose_test") op_test(name = "op_div_test") op_test(name = "op_gelu_test") op_test(name = "op_mul_test") diff --git a/kernels/test/targets.bzl b/kernels/test/targets.bzl index 789179c4cad..941e42ba1d4 100644 --- a/kernels/test/targets.bzl +++ b/kernels/test/targets.bzl @@ -1,14 +1,14 @@ load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime") load("@fbsource//xplat/executorch/kernels/test:util.bzl", "codegen_function_header_wrapper", "generated_op_test", "op_test") -def _common_op_test(name, kernels, aten_compatible = True): +def _common_op_test(name, kernels): """ Defines test targets in format of _op__test For ATen kernel testing, let's use portable functions.yaml for tested ops. """ for kernel in kernels: deps = [":function_header_wrapper_{}".format(kernel)] - op_test(name, aten_compatible = aten_compatible, kernel_name = kernel, use_kernel_prefix = True, deps = deps) + op_test(name, kernel_name = kernel, use_kernel_prefix = True, deps = deps) def make_example_generated_op_test_target(): """ diff --git a/kernels/test/util.bzl b/kernels/test/util.bzl index 0efeb497740..c2158bfab58 100644 --- a/kernels/test/util.bzl +++ b/kernels/test/util.bzl @@ -1,7 +1,7 @@ load("@fbsource//tools/build_defs:fbsource_utils.bzl", "is_xplat") load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime") -def op_test(name, deps = [], aten_compatible = True, kernel_name = "portable", use_kernel_prefix = False): +def op_test(name, deps = [], kernel_name = "portable", use_kernel_prefix = False): """Defines a cxx_test() for an "op_*_test.cpp" file. Args: @@ -11,8 +11,6 @@ def op_test(name, deps = [], aten_compatible = True, kernel_name = "portable", u under //kernels//...; e.g., "op_add_test" will depend on "//kernels/portable/cpu:op_add". deps: Optional extra deps to add to the cxx_test(). - aten_compatible: If True, the operator under test is ATen-compatible - (i.e., appears in `functions.yaml`). kernel_name: The name string as in //executorch/kernels/. use_kernel_prefix: If True, the target name is _op__test. Used by common kernel testing.