Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe a bug in invoking UpdateReadyCount in PMTraceConsumer::AddPresentToCompletedList #374

Open
otaku690 opened this issue Dec 5, 2024 · 0 comments
Open

Maybe a bug in invoking UpdateReadyCount in PMTraceConsumer::AddPresentToCompletedList #374

otaku690 opened this issue Dec 5, 2024 · 0 comments

Comments

@otaku690
Copy link

otaku690 commented Dec 5, 2024

PresentMon/PresentData/PresentMonTraceConsumer.cpp

Line 2010 in f5b8b75

UpdateReadyCount(deferredPresent, false);

Should the second argument true?
Based on comment in line 2008, it looks like we want to lock the mutex in UpdateReadyCount.
@otaku690 otaku690 changed the title Bug in invoking UpdateReadyCount in PMTraceConsumer::AddPresentToCompletedList Maybe a bug in invoking UpdateReadyCount in PMTraceConsumer::AddPresentToCompletedList Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@otaku690