From 7d7cc82ee9f26d3201e8e8e61469ced7d0282d58 Mon Sep 17 00:00:00 2001
From: Theophilus <60826700+Extheoisah@users.noreply.github.com>
Date: Tue, 11 Apr 2023 13:16:55 +0100
Subject: [PATCH] fix: hooks dependencies (#443)

---
 .../ParsePOSPayment/Receive-Invoice.tsx       | 60 +++++++++----------
 components/PaymentOutcome/index.tsx           |  8 +--
 2 files changed, 33 insertions(+), 35 deletions(-)

diff --git a/components/ParsePOSPayment/Receive-Invoice.tsx b/components/ParsePOSPayment/Receive-Invoice.tsx
index b5af0169..de5a97f2 100644
--- a/components/ParsePOSPayment/Receive-Invoice.tsx
+++ b/components/ParsePOSPayment/Receive-Invoice.tsx
@@ -1,7 +1,7 @@
 import copy from "copy-to-clipboard"
 import Link from "next/link"
 import { useRouter } from "next/router"
-import React from "react"
+import React, { useCallback } from "react"
 import { Button, Modal } from "react-bootstrap"
 import Image from "react-bootstrap/Image"
 import OverlayTrigger from "react-bootstrap/OverlayTrigger"
@@ -31,6 +31,9 @@ interface Props {
 const USD_MAX_INVOICE_TIME = "5.00"
 
 function ReceiveInvoice({ recipientWalletCurrency, walletId, state, dispatch }: Props) {
+  const OS = getOS()
+  const deviceDetails = window.navigator.userAgent
+
   const { username, amount, unit, sats, memo } = useRouter().query
   const { usdToSats, satsToUsd } = useSatPrice()
 
@@ -130,10 +133,34 @@ function ReceiveInvoice({ recipientWalletCurrency, walletId, state, dispatch }:
     })
   }, [amount, walletId, paymentAmount, createInvoice, memo])
 
+  const isMobileDevice = useCallback(() => {
+    const mobileDevice = /android|iPhone|iPod|kindle|HMSCore|windows phone|ipad/i
+    if (window.navigator.maxTouchPoints > 1 || mobileDevice.test(deviceDetails)) {
+      return true
+    }
+    return false
+  }, [deviceDetails])
+
+  const isDesktopType = useCallback(() => {
+    const desktopType = /Macintosh|linux|Windows|Ubuntu/i
+    const type = deviceDetails.match(desktopType)
+    return type?.[0]
+  }, [deviceDetails])
+
+  const fallbackUrl =
+    OS === "ios" ? appStoreLink : OS === "android" ? playStoreLink : apkLink
+
+  const handleLinkClick = () => {
+    if (isDesktopType() === "Macintosh") {
+      return window.open(appStoreLink, "_blank")
+    }
+    return window.open(playStoreLink, "_blank")
+  }
+
   React.useEffect(() => {
     isMobileDevice()
     isDesktopType()
-  }, [])
+  }, [isDesktopType, isMobileDevice])
 
   const errorString: string | null = errorsMessage || null
   let invoice: LnInvoiceObject | undefined
@@ -164,35 +191,6 @@ function ReceiveInvoice({ recipientWalletCurrency, walletId, state, dispatch }:
     }, 3000)
   }
 
-  const OS = getOS()
-  const deviceDetails = window.navigator.userAgent
-
-  const isMobileDevice = (): boolean => {
-    // check if device is being used on the web or mobile
-    const mobileDevice = /android|iPhone|iPod|kindle|HMSCore|windows phone|ipad/i
-
-    if (window.navigator.maxTouchPoints > 1 || mobileDevice.test(deviceDetails)) {
-      return true
-    }
-    return false
-  }
-
-  const isDesktopType = () => {
-    const desktopType = /Macintosh|linux|Windows|Ubuntu/i
-    const type = deviceDetails.match(desktopType)
-    return type?.[0]
-  }
-
-  const fallbackUrl =
-    OS === "ios" ? appStoreLink : OS === "android" ? playStoreLink : apkLink
-
-  const handleLinkClick = () => {
-    if (isDesktopType() === "Macintosh") {
-      return window.open(appStoreLink, "_blank")
-    }
-    return window.open(playStoreLink, "_blank")
-  }
-
   if ((errorString && !loading) || expiredInvoiceError) {
     const invalidInvoiceError =
       recipientWalletCurrency === "USD" && Number(amount?.toString()) <= 0
diff --git a/components/PaymentOutcome/index.tsx b/components/PaymentOutcome/index.tsx
index f6262e11..737c5628 100644
--- a/components/PaymentOutcome/index.tsx
+++ b/components/PaymentOutcome/index.tsx
@@ -21,14 +21,14 @@ function PaymentOutcome({ paymentRequest, paymentAmount, dispatch }: Props) {
   const { satsToUsd } = useSatPrice()
   const componentRef = useRef<HTMLDivElement | null>(null)
 
-  if (!paymentRequest) {
-    return null
-  }
-
   const printReceipt = useReactToPrint({
     content: () => componentRef.current,
   })
 
+  if (!paymentRequest) {
+    return null
+  }
+
   const { loading, data, error, errorsMessage } = useSubscription.lnInvoicePaymentStatus({
     variables: {
       input: { paymentRequest },