From a8fa91f1edb1bd774b5b254f23d7def2b333f57e Mon Sep 17 00:00:00 2001
From: bodymindarts <justin@galoy.io>
Date: Wed, 25 May 2022 09:54:08 +0200
Subject: [PATCH] fix: objects-list role name

---
 modules/inception/gcp/tf-state-bucket.tf |  2 +-
 modules/inception/gcp/variables.tf       | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/modules/inception/gcp/tf-state-bucket.tf b/modules/inception/gcp/tf-state-bucket.tf
index 93682e0d..93456d7c 100644
--- a/modules/inception/gcp/tf-state-bucket.tf
+++ b/modules/inception/gcp/tf-state-bucket.tf
@@ -10,7 +10,7 @@ resource "google_storage_bucket" "tf_state" {
 
 resource "google_project_iam_custom_role" "list_objects" {
   project     = local.project
-  role_id     = local.object_list_role_name
+  role_id     = local.objects_list_role_name
   title       = "List bucket Objects"
   description = "Role to _only_ list objects (not get them) from ${local.name_prefix}"
   permissions = [
diff --git a/modules/inception/gcp/variables.tf b/modules/inception/gcp/variables.tf
index 357325a9..6a624f1c 100644
--- a/modules/inception/gcp/variables.tf
+++ b/modules/inception/gcp/variables.tf
@@ -21,8 +21,8 @@ variable "bastion_revoke_on_exit" {
 variable "network_prefix" {
   default = "10.0"
 }
-variable "object_list_role_name" {
-  default = "object-list"
+variable "objects_list_role_name" {
+  default = "objects-list"
 }
 
 variable "inception_sa" {}
@@ -53,9 +53,9 @@ locals {
   platform_admins          = concat([for user in var.users : user.id if user.platform], ["serviceAccount:${var.inception_sa}"])
   bastion_users            = toset(concat([for user in var.users : user.id if user.bastion], local.platform_admins))
 
-  region                = var.region
-  network_prefix        = var.network_prefix
-  object_list_role_name = replace("${local.name_prefix}-${var.object_list_role_name}", "-", "_")
+  region                 = var.region
+  network_prefix         = var.network_prefix
+  objects_list_role_name = replace("${local.name_prefix}-${var.objects_list_role_name}", "-", "_")
 
   cluster_location       = var.cluster_zone == "" ? local.region : "${local.region}-${var.cluster_zone}"
   bastion_zone           = "${local.region}-${var.primary_zone}"