Update to include support for LLVM versions 11 and 12. #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kquick
changed the title
|
The update to the llvm-pretty and llvm-pretty-bc-parser now cause the MacOS tests (running Clang 11) to run further. The single test failure is presumably not a crucible issue but a behavior difference in output flushing introduced in LLVM 11? [I can get the same failure under Linux using Clang/LLVM 11 there as well.] If that is the case, the expected test results can be most easily parameterized for LLVM version in pending PR #618. I therefore recommend merging this PR as an improvement and addressing the difference in expected test output via PR #618. |
atomb
approved these changes
Jan 27, 2021
robdockins
approved these changes
Jan 28, 2021
This was referenced Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.