Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake, docker, FactGenerator: iwyu #110

Closed
wants to merge 2 commits into from
Closed

cmake, docker, FactGenerator: iwyu #110

wants to merge 2 commits into from

Conversation

langston-barrett
Copy link
Collaborator

Fixes #109.

I'm not enough of a C++ hacker to understand the quality of these suggestions. On the one hand, maybe that means I shouldn't mess with them. On the other hand, maybe it means I should trust the automated tool that encodes best practices (like I do with clang-tidy). @thinkmoore penny for your thoughts?

TBQH, I'm not enough of a C++ programmer to really know if these are great
suggestions. The removals seem good, but are the additions?
@langston-barrett
Copy link
Collaborator Author

Confusing:

-- The C compiler identification is Clang 10.0.0
-- The CXX compiler identification is Clang 10.0.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found LLVM 10.0.0
-- Using LLVMConfig.cmake in: /usr/lib/llvm-10/cmake
-- Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.71.0/BoostConfig.cmake (found suitable version "1.71.0", minimum required is "1.71") found components: system filesystem program_options iostreams 
-- Found OpenMP_C: -fopenmp=libomp (found version "4.5") 
-- Found OpenMP_CXX: -fopenmp=libomp (found version "4.5") 
-- Found OpenMP: TRUE (found version "4.5")  
-- Configuring done
-- Generating done
-- Build files have been written to: /work/build
[1/51] Building CXX object CMakeFiles/factgen-exe.dir/FactGenerator/src/main.cpp.o
FAILED: CMakeFiles/factgen-exe.dir/FactGenerator/src/main.cpp.o 
/usr/bin/cmake -E __run_co_compile --iwyu=/usr/bin/include-what-you-use -- /usr/bin/c++  -DBOOST_ALL_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_IOSTREAMS_DYN_LINK -DBOOST_PROGRAM_OPTIONS_DYN_LINK -DBOOST_SYSTEM_DYN_LINK -isystem /usr/lib/llvm-10/include -isystem ../FactGenerator/include -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -std=gnu++17 -MD -MT CMakeFiles/factgen-exe.dir/FactGenerator/src/main.cpp.o -MF CMakeFiles/factgen-exe.dir/FactGenerator/src/main.cpp.o.d -o CMakeFiles/factgen-exe.dir/FactGenerator/src/main.cpp.o -c ../FactGenerator/src/main.cpp
Error running '/usr/bin/include-what-you-use': In file included from ../FactGenerator/src/main.cpp:1:
In file included from /usr/lib/llvm-10/include/llvm/ADT/Optional.h:19:
In file included from /usr/lib/llvm-10/include/llvm/Support/Compiler.h:21:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/new:40:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/exception:143:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/9/../../../../include/c++/9/bits/exception_ptr.h:[38](https://github.com/GaloisInc/cclyzerpp/actions/runs/3340579892/jobs/5530842719#step:5:39):
/usr/bin/../lib/gcc/x86_[64](https://github.com/GaloisInc/cclyzerpp/actions/runs/3340579892/jobs/5530842719#step:5:65)-linux-gnu/9/../../../../include/c++/9/bits/cxxabi_init_exception.h:38:10: fatal error: 'stddef.h' file not found
#include <stddef.h>
         ^~~~~~~~~~
Segmentation fault

@langston-barrett langston-barrett deleted the lb/iwyu branch February 8, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmake, ci: Lint with include-what-you-use
1 participant