Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally describe what this PR will do, and why it is needed
This adds support for Cycles light-linking, as well as shadow groups (however it is using the Arnold
ai:visibility:shadow_group
attribute for now until the renderer interface gets updated)Should this PR also add a
StandardAttributes
for shadow groups, now that Cycles supports them and not just Arnold?We will also need a shadow-link test but perhaps it should be added as a global test once it is a standard attribute
I'd love to have new eyes on this as well, as it's a lot of code (however I've been doing some extensive testing and bug-fixing especially for live rendering updates already).
Related issues
Dependencies
Breaking changes
Lights
set so it now gets created like a light, which is needed so that light-linking and shadow groups can work. I've also removed disabling visibility flags as it works differently to Arnold here and they shouldn't be turned off by default (a user can still modify them using aCyclesAttributes
if they wish).Checklist