Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycles : Light-linking #5604

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

boberfly
Copy link
Collaborator

Generally describe what this PR will do, and why it is needed

  • This adds support for Cycles light-linking, as well as shadow groups (however it is using the Arnold ai:visibility:shadow_group attribute for now until the renderer interface gets updated)

  • Should this PR also add a StandardAttributes for shadow groups, now that Cycles supports them and not just Arnold?

  • We will also need a shadow-link test but perhaps it should be added as a global test once it is a standard attribute

  • I'd love to have new eyes on this as well, as it's a lot of code (however I've been doing some extensive testing and bug-fixing especially for live rendering updates already).

Related issues

  • NA

Dependencies

Breaking changes

  • CyclesMeshLight now adds those particular meshes to the Lights set so it now gets created like a light, which is needed so that light-linking and shadow groups can work. I've also removed disabling visibility flags as it works differently to Arnold here and they shouldn't be turned off by default (a user can still modify them using a CyclesAttributes if they wish).

Checklist

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable.
  • I have tested my change(s) in the test suite, and added new test cases where necessary.
  • My code follows the Gaffer project's prevailing coding style and conventions.

@boberfly boberfly force-pushed the update/cycles_lightlink branch 3 times, most recently from ea95ea3 to b44fc2e Compare December 29, 2023 08:15
@boberfly boberfly force-pushed the update/cycles_lightlink branch from b44fc2e to 651347b Compare March 16, 2024 11:50
@boberfly boberfly force-pushed the update/cycles_lightlink branch from 651347b to b5c13be Compare March 16, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant