Sign in #25
Sign in #25
Conversation
| 'https://www.googleapis.com/auth/contacts.readonly', | ||
| ], | ||
| ); | ||
| static GoogleSignInAccount currentUser; |
There was a problem hiding this comment.
don't need (if we use stream builder)
| super.initState(); | ||
| SignIn.googleSignIn.onCurrentUserChanged | ||
| .listen((GoogleSignInAccount account) { | ||
| setState(() { | ||
| SignIn.currentUser = account; | ||
| }); | ||
| }); |
There was a problem hiding this comment.
dont do this. use stream builder
| static GoogleSignIn googleSignIn = GoogleSignIn( | ||
| scopes: <String>[ | ||
| 'email', | ||
| 'https://www.googleapis.com/auth/contacts.readonly', |
There was a problem hiding this comment.
what is this line for?
There was a problem hiding this comment.
Umm... I just forgot to get rid of it
| static Future<void> handleSignIn() async { | ||
| try { | ||
| await SignIn.googleSignIn.signIn(); | ||
| } catch (error) { | ||
| print(error); | ||
| } | ||
| } |
There was a problem hiding this comment.
this is a redundant function (you should just catch an error wherever you attempt sign in so it can properly presented to user)
| import 'package:google_sign_in/google_sign_in.dart'; | ||
|
|
||
| class SignIn { | ||
| static GoogleSignIn googleSignIn = GoogleSignIn( |
There was a problem hiding this comment.
keep this under getIt or just in the main file if it doesn't need multi file scope
| @@ -0,0 +1,19 @@ | |||
| import 'package:google_sign_in/google_sign_in.dart'; | |||
|
|
|||
| class SignIn { | |||
There was a problem hiding this comment.
this file (and class) isn't needed. see other comments
| import 'package:flutter/material.dart'; | ||
| import 'package:wpi_campus/services/sign_in.dart'; | ||
|
|
||
| class SignInDemo extends StatefulWidget { |
There was a problem hiding this comment.
delete this before we merge pr
| @@ -1,369 +0,0 @@ | |||
| # Generated by pub | |||
There was a problem hiding this comment.
probably don't want this file deleted
There was a problem hiding this comment.
maybe pop it in git ignore?
There was a problem hiding this comment.
I think I just removed it from git, but I can double check. It shouldn't be in version control
No description provided.