Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book search results are not paged #17

Open
GaProgMan opened this issue Nov 1, 2017 · 0 comments
Open

Book search results are not paged #17

GaProgMan opened this issue Nov 1, 2017 · 0 comments

Comments

@GaProgMan
Copy link
Owner

Repro steps

  • Head to /books and search with a blank string
  • All book records from the database are eventually returned
  • Because images are included in the search results, the response from the API server can take up to 19 seconds (on a relatively OK connection)

Suggestions for improvement

  • Return paged data (e.g. first 10 records only)
  • As user scrolls to the bottom of the page, send a get request for more records (e.g. infinite scroll)
  • Load the text data separate from the images (fire a second get request for the images, using a loading spinner as each record's image until the response comes back)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant