Missing erase after remove_if #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentRouvreau
approved these changes
Sep 21, 2023
| @@ -76,7 +76,16 @@ int main(int argc, char**argv) { | |||
| << " vs metric " << std::chrono::duration_cast<std::chrono::milliseconds>((time_stop2 - time_start2)).count() | |||
| << " (Boost version " << BOOST_VERSION << ")\n"; | |||
| if (dists != dists2 || results != results2) { | |||
| // Note that with many points, it often happens that 2 points with the same distance are swapped in the output. | |||
| std::cerr << "Results differ\n"; | |||
There was a problem hiding this comment.
Does it happen that results differ ? I was not able to reach this code.
There was a problem hiding this comment.
With 100k points and seed 0, I get 1 swap. With 50k points, I need to try several seeds before I get a swap. (I don't remember if this was dimension 2 or 4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #964.
I don't know how I managed to miss that... It was in a place where the code was still valid, and the slowdown was limited enough not to make the runtime seem strange. Good thing one compiler decided to warn about it.
It does not seem to impact the result (good), but it does improve performance (something like 20%, depending on the input).