[Persistence matrix] Better additions in U for RU matrices in Z2 #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mglisse
approved these changes
Oct 18, 2024
| * | ||
| * @param entry Entry to push back. | ||
| */ | ||
| void push_back(const Entry& entry); |
There was a problem hiding this comment.
I think I would have preferred a name like insert_pivot or insert_max_entry, but this is ok for now.
| @@ -615,7 +615,7 @@ inline void Base_matrix<Master_matrix>::print() | |||
| if constexpr (Master_matrix::Option_list::has_row_access) { | |||
| std::cout << "Row Matrix:\n"; | |||
| for (Index i = 0; i < nextInsertIndex_; ++i) { | |||
| const auto& row = RA_opt::rows_[i]; | |||
| const auto& row = (*RA_opt::rows_)[i]; | |||
There was a problem hiding this comment.
Just to confirm: this is a bugfix independent of the main goal of the PR, right?
There was a problem hiding this comment.
Yes, I stumbled over it while testing the new strategy.
Comment on lines
+652
to
+653
| static_assert(!Master_matrix::Option_list::is_z2, | ||
| "Multiplication with something else than the identity is not allowed with Z2 coefficients."); |
There was a problem hiding this comment.
How do you know that the argument is not the identity?
There was a problem hiding this comment.
I don't know, I just wanted to say that for Z2 add_to should be used in all cases, as multiplying by 0 the column is likely an error and a bit costly to implement as U is transposed.
VincentRouvreau
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small optimization for the reduction of U in the RU decomposition. It does not make a big difference for small complexes, but divides by two the reduction time for big complexes.
The difference is mostly at line 851 of
RU_matrix.h.