Potentially erroneous assertion in Hera?

[gspr]

This is really an issue in Hera, but it seems to affect GUDHI very directly. I have higher hopes of seeing a response here.

Until some weeks ago, the GUDHI Debian packages accidentally built the (C++ part of the) Python bindings with -DNDEBUG, thus disabling all assertions. After that was changed, I've been seeing the test suite fail. That failure seems to stem from this assertion in Hera. I'm not well-versed in the Hera code, but the assertion seems wrong to me. Won't every point in the loop just above the assertion pass the if_normal test in case of entirely-off-diagonal persistence diagrams? Then the assertion trivially fails.

This in turn causes problems for GUDHI – for example, this part of a test fails on the assertion failing. This might not easily get caught if one, like me, accidentally builds with -DNDEBUG.

Am I missing something?