Simplex tree ctors with data #1151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rming constructor
hschreiber
reviewed
Nov 13, 2024
There was a problem hiding this comment.
Is it wanted that the non assigned data seems to take a random value ? For unit test "simplex_data", the output is:
(2 1 0 ) filtration=0 - data='4'
(1 0 ) filtration=0 - data='5'
(2 0 ) filtration=0 - data='43808336'
(0 ) filtration=0 - data='2'
(2 1 ) filtration=0 - data='43808304'
(1 ) filtration=0 - data='43808304'
(2 ) filtration=0 - data='43808304'
Data is of type int and only 4 and 5 were assigned.
Co-authored-by: hschreiber <[email protected]>
Co-authored-by: hschreiber <[email protected]>
Co-authored-by: hschreiber <[email protected]>
It is the behaviour we want. We do not say it, but data are not initialized with a default value, that would take time. It is up to the user to deal with it. |
…reau/gudhi-devel into simplex_tree_ctors_with_data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rec_copycan copy or notsimplex_data.Some documentation and tests to explain when data are copied or not.
Fix #1127