Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default dim in DTMDensity for high dimension #1075

Open
mglisse opened this issue Jun 16, 2024 · 0 comments
Open

Change default dim in DTMDensity for high dimension #1075

mglisse opened this issue Jun 16, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@mglisse
Copy link
Member

mglisse commented Jun 16, 2024

In DTMDensity (and Tomato), when the points are in "high" dimension, we recommend using a small value for dim instead of the default: the ambient dimension. But if we recommend it, why not make it the default behavior? Something like

  • if dim=None and the deduction would choose a value larger than 10 (?), then just pick 10 (or even go down to 2 while we are at it?) and print a warning advertising the next point
  • if dim is specified by the user, they can use any value they like

DTMDensity (without normalization) ends with density = dtm ** (-dim / q). This exponentiation is pretty useless if we are only going to use it in a log in Tomato's logDTM. Without it, only q needs to be small enough, dim becomes unused, and the behavior matches Tomato's doc before #1074.

@mglisse mglisse added the enhancement New feature or request label Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant