Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sklearn set_output #1015

Open
1 task
mglisse opened this issue Dec 22, 2023 · 1 comment
Open
1 task

sklearn set_output #1015

mglisse opened this issue Dec 22, 2023 · 1 comment

Comments

@mglisse
Copy link
Member

mglisse commented Dec 22, 2023

Since version 1.2, scikit-learn has a set_output API that can make transformers output pandas dataframes.

  • Investigate how that affects us.
@mglisse
Copy link
Member Author

mglisse commented Jun 25, 2024

@martinroyer suggests adding to RipsPersistence

def get_feature_names_out(self):
    return [f"H{i}" for i in self.homology_dimensions]

so that RipsPersistence(homology_dimensions=[0, 2]).set_output(transform="pandas").fit_transform([X]) can output a pandas dataframe with column labels "H0" and "H2".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant