From 44e7fef803ccd840f0b6cbc3918685c57d25a97e Mon Sep 17 00:00:00 2001 From: Vincent Rouvreau Date: Tue, 10 Dec 2024 10:15:59 +0100 Subject: [PATCH 1/4] New docker image build should fix libc issues --- .github/workflows/pip-build-linux.yml | 2 +- .github/workflows/pip-packaging-linux.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pip-build-linux.yml b/.github/workflows/pip-build-linux.yml index f7c88d34d..3c8b80442 100644 --- a/.github/workflows/pip-build-linux.yml +++ b/.github/workflows/pip-build-linux.yml @@ -11,7 +11,7 @@ jobs: name: build pip wheel runs-on: ubuntu-latest # cf. https://github.com/GUDHI/gudhi-deploy/blob/main/Dockerfile_for_pip - container: gudhi/pip_for_gudhi:2024.10.02 + container: gudhi/pip_for_gudhi:2024.12.01 steps: # Should use actions/checkout@v4, but requires node20, not available for quay.io/pypa/manylinux2014_x86_64 - uses: actions/checkout@v3 diff --git a/.github/workflows/pip-packaging-linux.yml b/.github/workflows/pip-packaging-linux.yml index a649baa03..18a6024dc 100644 --- a/.github/workflows/pip-packaging-linux.yml +++ b/.github/workflows/pip-packaging-linux.yml @@ -9,7 +9,7 @@ jobs: name: build pip wheel runs-on: ubuntu-latest # cf. https://github.com/GUDHI/gudhi-deploy/blob/main/Dockerfile_for_pip - container: gudhi/pip_for_gudhi:2024.10.02 + container: gudhi/pip_for_gudhi:2024.12.01 steps: # Should use actions/checkout@v4, but requires node20, not available for quay.io/pypa/manylinux2014_x86_64 - uses: actions/checkout@v3 From 90b10446c9c053a29f9cf7b5449d53800be5f159 Mon Sep 17 00:00:00 2001 From: Vincent Rouvreau Date: Tue, 10 Dec 2024 11:40:35 +0100 Subject: [PATCH 2/4] Try with gudhi/pip_for_gudhi:2024.12.02 based on quay.io/pypa/manylinux_2_28_x86_64 --- .github/workflows/pip-build-linux.yml | 2 +- .github/workflows/pip-packaging-linux.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pip-build-linux.yml b/.github/workflows/pip-build-linux.yml index 3c8b80442..f923ff100 100644 --- a/.github/workflows/pip-build-linux.yml +++ b/.github/workflows/pip-build-linux.yml @@ -11,7 +11,7 @@ jobs: name: build pip wheel runs-on: ubuntu-latest # cf. https://github.com/GUDHI/gudhi-deploy/blob/main/Dockerfile_for_pip - container: gudhi/pip_for_gudhi:2024.12.01 + container: gudhi/pip_for_gudhi:2024.12.02 steps: # Should use actions/checkout@v4, but requires node20, not available for quay.io/pypa/manylinux2014_x86_64 - uses: actions/checkout@v3 diff --git a/.github/workflows/pip-packaging-linux.yml b/.github/workflows/pip-packaging-linux.yml index 18a6024dc..b753887d9 100644 --- a/.github/workflows/pip-packaging-linux.yml +++ b/.github/workflows/pip-packaging-linux.yml @@ -9,7 +9,7 @@ jobs: name: build pip wheel runs-on: ubuntu-latest # cf. https://github.com/GUDHI/gudhi-deploy/blob/main/Dockerfile_for_pip - container: gudhi/pip_for_gudhi:2024.12.01 + container: gudhi/pip_for_gudhi:2024.12.02 steps: # Should use actions/checkout@v4, but requires node20, not available for quay.io/pypa/manylinux2014_x86_64 - uses: actions/checkout@v3 From e6fd39818bb5ccb1956c251f71d2bce7f792dae2 Mon Sep 17 00:00:00 2001 From: Vincent Rouvreau Date: Tue, 10 Dec 2024 14:50:51 +0100 Subject: [PATCH 3/4] Try to upgrade actions/checkout and actions/upload-artifact to v4 --- .github/workflows/pip-build-linux.yml | 6 ++---- .github/workflows/pip-packaging-linux.yml | 3 +-- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/.github/workflows/pip-build-linux.yml b/.github/workflows/pip-build-linux.yml index f923ff100..ddf6612ef 100644 --- a/.github/workflows/pip-build-linux.yml +++ b/.github/workflows/pip-build-linux.yml @@ -13,8 +13,7 @@ jobs: # cf. https://github.com/GUDHI/gudhi-deploy/blob/main/Dockerfile_for_pip container: gudhi/pip_for_gudhi:2024.12.02 steps: - # Should use actions/checkout@v4, but requires node20, not available for quay.io/pypa/manylinux2014_x86_64 - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: submodules: true - name: Build wheel for Python 3.9 @@ -37,8 +36,7 @@ jobs: $PYTHON39/bin/python -m pytest -v src/python/test/test_cubical_complex.py $PYTHON39/bin/python -m pytest -v src/python/test/test_rips_complex.py - name: Upload linux python wheel - # Should use actions/upload-artifact@v4, but requires node20, not available for quay.io/pypa/manylinux2014_x86_64 - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: linux python wheel path: build_39/src/python/wheelhouse/*.whl diff --git a/.github/workflows/pip-packaging-linux.yml b/.github/workflows/pip-packaging-linux.yml index b753887d9..4bb56e326 100644 --- a/.github/workflows/pip-packaging-linux.yml +++ b/.github/workflows/pip-packaging-linux.yml @@ -11,8 +11,7 @@ jobs: # cf. https://github.com/GUDHI/gudhi-deploy/blob/main/Dockerfile_for_pip container: gudhi/pip_for_gudhi:2024.12.02 steps: - # Should use actions/checkout@v4, but requires node20, not available for quay.io/pypa/manylinux2014_x86_64 - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: submodules: true # Python 3.8 specific case where NumPy 2.x will not be supported From 87e7088578ca6e957bb637741ab21906250791a2 Mon Sep 17 00:00:00 2001 From: Vincent Rouvreau Date: Tue, 10 Dec 2024 15:55:41 +0100 Subject: [PATCH 4/4] try to remove ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION --- .github/workflows/pip-build-linux.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/pip-build-linux.yml b/.github/workflows/pip-build-linux.yml index ddf6612ef..2bfa253ad 100644 --- a/.github/workflows/pip-build-linux.yml +++ b/.github/workflows/pip-build-linux.yml @@ -2,10 +2,6 @@ name: pip build linux on: [push, pull_request] -# Temporary workaround to allow node16 -env: - ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true - jobs: build: name: build pip wheel